Fixed forced time acceleration - but can't upload to git

[clausimu]

Hello,

Some time ago I had experimented with scripts using wingmen that follow you around. The problem was that time acceleration was limited to 10x and forced time acceleration (pressing Ctrl while selecting) did not work. I checked the code and found that being fired on and being close to another ship are treated as exceptions that don't allow forced acceleration. I changed it to allow forced acceleration when another ship is close - but not when you are fired on.

My problem is - I have never worked with C++ or git, just getting started. The fix works fine on my machine and I have tried to upload it to git using the following commands:

Code: Select all

git checkout -b forced_time_acceleration
git commit -a -m "Enabled forced time acceleration"
git push origin forced_time_acceleration
 

The first two work fine - but when I try the last one I am asked to enter a login/password that are apparently not accepted ("remote: Permission to pioneerspacesim/pioneer.git denied to clausimu"). Using the same login/password I can login to git just fine in my browser.

Am I missing something? Do I need another set of credentials for pushing something to the pioneer repository?

Thank you,
Claudius

[bszlrd]

Hi

You can't push directly to the master as far as I know, only if you have permission at least.
The way we do it is putting up a pull request, which then gets some review/discussion from the folks to see if anything's off, then it will be merged when it's ready.
I'm not a git guru, but how I it do with my assets: I push the branch with my changes/additions to my repository, and then I go to my repository on the github page, and it will offer me a Compare&Pull request option for my latest branch. I put in some description, and sometimes images, then off it goes.

This page on our wiki provides a more detailed description of the process.

Hope this helps.

[clausimu]

Thank you for the quick help! The wiki link is great too - don't know how I missed that. I got it done and put the pull request in.