Pioneer dev forum

If you're in a compiling and testing kind of mood, I'd love to get some eyeballs on PR #2589, the new station screens.

Note that right now I'm looking for technical issues (missing/broken functionality, crashes, other quirks). I'm not so interested in disagreements about layouts and presentation. Not that that's not important but its usually the case that everyone has different but equal opinions, and I'd rather not hold this back while everyone says their piece. You're quite welcome to hack the code later to produce your dream layout - that's half the reason its all moved out to Lua! :)

Screenshots from the PR:

Looks very nice.

As mentioned in #pioneer, the "take off clearance" button is missing.

Also, nice feature to have would be:
- Arrow up / down for scrolling lists.
- F4 cycles through the different tabs in "Lobby, Bulletin Board, etc"
- F3 cycles through the different tabs in "Ship Information, Personal information, etc"

impaktor wrote:As mentioned in #pioneer, the "take off clearance" button is missing.

That's done now, good catch:

- Arrow up / down for scrolling lists.

Needs some input layer support that I haven't fully thought through yet. Some other time.

- F4 cycles through the different tabs in "Lobby, Bulletin Board, etc"
- F3 cycles through the different tabs in "Ship Information, Personal information, etc"

This gets asked for a bit. I think it could be hacked by adding a shortcut to something for that key, but then that thing has to be clickable or magicked to be invisible. But it is needed. I'm going to throw it in the "input" bucket for now.

Wow I didn't realise you were doing ALL of the station screens! For some reason I thought you were just doing the trade screen first.

That looks great!!

Found a bit of an issue, it insists that my ship is perfectly intact and doesn't need repairs despite it being almost totally ruined :/

Logged as issue https://github.com/pioneerspacesim/pioneer/issues/2598

I think we need a bigger screen for this:

Or more info. @robn Is there a way to resize the screen?

In other screens, client photos require a better frame or extension.

A doubt. 4:3 is still the standard?

walterar wrote:I think we need a bigger screen for this:
Or more info. @robn Is there a way to resize the screen?

Yeah, this is kind of crappy. It used to be a variable-sized dialog, but that would cause it to change sizes when the text changed, which made it really hard to use. So I forced it to be fixed, which obviously does this with large quantities of text (and I missed it, annoying).

I think the only other option with this style would be to add scrollbars, which would look terrible too. So the plan is to change the BB layout entirely to something more like this (a mockup by nozmajner):

In other screens, client photos require a better frame or extension.

Yeah, the face widget got a change to report its sizing differently to the UI core so I could do things like the really small ones in the chat forms sanely, but I deliberately didin't change anywhere else because the changeset was already too large. I've got some updates to the info screens coming soon to take advantage of some new UI features made for the station screens, so I'll leave it until then.

walterar wrote:A doubt. 4:3 is still the standard?

No, you cannot assume any screen size or ratio any more.