Map : reset after hyperspace and additional keyboard bindings

[micha]

Hi, I'm new, and just hacked around on something which was bugging me with the current release; namely the maps.

1. Reset selected system after hyperspace jump

After a hyperspace jump, very typically I want to open the current system map (either to check info, or set a target, etc). The current game does not reset the "selected system" after a jump which, to me at least, is somewhat confusing. My code now does.

As a bonus, it now signals as per a comment in Player::OnEnterSystem() - Game now emits an "onSystemEntered" signal, which the SectorView connects to. TBH I'm not entirely sure what the benefit of this is as the signal "handlers" appear to be getting called from within "emit" and not asynchronously. Is this just a design paradigm to decouple the classes?

2. Additional keyboard bindings

I'm also thinking about adding more keyboard binds to the Sector Map - moving the selection around between systems on a route, as well as being able to use the keyboard to set the jump destination or calculate a route. One challenge for setting the destination with the keyboard are multi-star systems.

----

1 is done; Adding more keybinds for 2 is fairly trivial based on some experimentation, a question is what we want to be able to control by keyboard (ideally everything as jumping between mouse and keyboard is cumbersome, but that would require some non-trivial rethinking of the UI as a whole).

Thoughts?

[zonkmachine]

1. Reset selected system after hyperspace jump

After a hyperspace jump, very typically I want to open the current system map (either to check info, or set a target, etc). The current game does not reset the "selected system" after a jump which, to me at least, is somewhat confusing. My code now does.

I believe this is discussed here: https://github.com/pioneerspacesim/pioneer/issues/5691

[micha]

Thank you; I did search through the issues list but didn't find that one, then I figured it was probably better to discuss here first before raising a new issue. I'll continue discussion there.